From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261482AbVFZRan (ORCPT ); Sun, 26 Jun 2005 13:30:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261503AbVFZRal (ORCPT ); Sun, 26 Jun 2005 13:30:41 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:27268 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261482AbVFZR2T (ORCPT ); Sun, 26 Jun 2005 13:28:19 -0400 Date: Sun, 26 Jun 2005 18:28:16 +0100 From: Christoph Hellwig To: David Masover Cc: Christoph Hellwig , Jeff Garzik , Hans Reiser , Andrew Morton , linux-kernel@vger.kernel.org, ReiserFS List Subject: Re: reiser4 plugins Message-ID: <20050626172816.GB19630@infradead.org> Mail-Followup-To: Christoph Hellwig , David Masover , Jeff Garzik , Hans Reiser , Andrew Morton , linux-kernel@vger.kernel.org, ReiserFS List References: <42B831B4.9020603@pobox.com> <42B87318.80607@namesys.com> <20050621202448.GB30182@infradead.org> <42B8B9EE.7020002@namesys.com> <42B8BB5E.8090008@pobox.com> <42B8E834.5030809@slaphack.com> <20050622053656.GB28228@infradead.org> <42B91764.1080208@slaphack.com> <20050626165246.GB18942@infradead.org> <42BEE430.7010505@slaphack.com> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <42BEE430.7010505@slaphack.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 26, 2005 at 12:21:52PM -0500, David Masover wrote: > I seem to remember the comment was more about hardcoded ID tables. > > And this was the generic ID code database, which is now maintained out > of the kernel: > > /usr/share/misc/pci.ids > A list of all known PCI ID's (vendors, devices, classes and sub-classes). > > That is what I was referring to, that used to be in the kernel. And you once again showed that you don't understand what you're talking about. Said database is a pci id to name mapping, which is completely irrelevant for any driver. For things like your example there's very little thing you can do but hardcoding a set of pci ids in one way or another. > What this has to do with is whether you believe that it's better to keep > code out until it's perfectly clean, or to let in code that has some I doesn't need to be perfect, we just need it in a reasonable state and have a buying that it's going to continue to evolve in the rigūt direction. And we're are very far from both of them in this ccase.