From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261704AbVF0HbZ (ORCPT ); Mon, 27 Jun 2005 03:31:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261893AbVF0HbZ (ORCPT ); Mon, 27 Jun 2005 03:31:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:13453 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S261704AbVF0H2d (ORCPT ); Mon, 27 Jun 2005 03:28:33 -0400 Date: Mon, 27 Jun 2005 09:28:32 +0200 From: Andi Kleen To: Jens Axboe Cc: Pekka Enberg , Andrew Morton , Jeff Mahoney , penberg@gmail.com, reiser@namesys.com, ak@suse.de, flx@namesys.com, zam@namesys.com, vs@thebsh.namesys.com, linux-kernel@vger.kernel.org, reiserfs-list@namesys.com Subject: Re: -mm -> 2.6.13 merge status Message-ID: <20050627072832.GA14251@wotan.suse.de> References: <42B86027.3090001@namesys.com> <20050621195642.GD14251@wotan.suse.de> <42B8C0FF.2010800@namesys.com> <84144f0205062223226d560e41@mail.gmail.com> <42BB0151.3030904@suse.de> <20050623114318.5ae13514.akpm@osdl.org> <20050623193247.GC6814@suse.de> <1119717967.9392.2.camel@localhost> <20050627072449.GF19550@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050627072449.GF19550@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > On Thu, 2005-06-23 at 21:32 +0200, Jens Axboe wrote: > > > That said, I don't like the reiser name-number style. If you must do > > > something like this, mark responsibility by using a named identifier > > > covering the layer in question instead. > > > > > > assert("trace_hash-89", is_hashed(foo) != 0); > > > > A human readable message would be nicer. For example, "foo was hashed". > > Indeed. You can just dump the expression (with #argument). That is what traditional userspace assert did forever. It won't help for BUG_ON(a || b || c || d || e) but these are bad style anyways and should be avoided. -Andi