mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: greg@kroah.com, jeff.garzik@pobox.com, akpm@osdl.org, torvalds@osdl.org
Subject: [Patch] Janitorial cleanup of GET_INDEX macro in arch/i386/pci/fixup.c
Date: Mon, 27 Jun 2005 10:09:14 -0400	[thread overview]
Message-ID: <20050627140914.GD20880@hmsendeavour.rdu.redhat.com> (raw)

Patch to clean up the implementation of the GET_INDEX macro in the i386 pci
fixup code so that it uses the PCI_DEVFN macro, rather than re-implements it.

Thanks and Regards
Neil

Signed-off-by: Neil Horman <nhorman@redhat.com>

 fixup.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


--- linux-2.6.git/arch/i386/pci/fixup.c.orig	2005-06-27 09:42:31.000000000 -0400
+++ linux-2.6.git/arch/i386/pci/fixup.c	2005-06-27 09:43:46.000000000 -0400
@@ -253,7 +253,7 @@
 #define MAX_PCIEROOT	6
 static int quirk_aspm_offset[MAX_PCIEROOT << 3];
 
-#define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + ((b) & 7))
+#define GET_INDEX(a, b) PCI_DEVFN((a - PCI_DEVICE_ID_INTEL_MCH_PA),b)
 
 static int quirk_pcie_aspm_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *value)
 {
-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@redhat.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

             reply	other threads:[~2005-06-27 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-27 14:09 Neil Horman [this message]
2005-06-27 22:19 ` Linus Torvalds
2005-06-27 22:32   ` Greg KH
2005-06-28 17:13     ` Jeff Garzik
2005-06-30  6:42       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050627140914.GD20880@hmsendeavour.rdu.redhat.com \
    --to=nhorman@redhat.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=jeff.garzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®