From: "David S. Miller" <davem@davemloft.net>
To: dcb314@hotmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: variable used before it is set
Date: Tue, 28 Jun 2005 02:26:04 -0700 (PDT) [thread overview]
Message-ID: <20050628.022604.02288401.davem@davemloft.net> (raw)
In-Reply-To: <BAY19-F15587C5037C178B447330E9CE10@phx.gbl>
From: "d binderman" <dcb314@hotmail.com>
Date: Tue, 28 Jun 2005 09:16:56 +0000
> net/bridge/netfilter/ebt_log.c(91): remark #592: variable "u" is used before
> its value is set
> printk(" IP tos=0x%02X, IP proto=%d", u.iph.tos,
> ^
> I agree with the compiler. Suggest code rework.
I added this bug, I'll fix it. It should use iph->tos
instead, and the entire 'u' array on the local stack
removed since there are then no more users of it.
next prev parent reply other threads:[~2005-06-28 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 9:16 d binderman
2005-06-28 9:26 ` David S. Miller [this message]
2005-06-28 9:32 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628.022604.02288401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®