From: Andrew Morton <akpm@osdl.org>
To: Marco Colombo <marco@esi.it>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Tracking down a memory leak
Date: Tue, 28 Jun 2005 04:02:17 -0700 [thread overview]
Message-ID: <20050628040217.0132d9cc.akpm@osdl.org> (raw)
In-Reply-To: <1119950283.26948.271.camel@Frodo.esi>
Marco Colombo <marco@esi.it> wrote:
>
> Thanks to everybody who replied to me. Here's more data:
>
> sh-2.05b# sort -rn +1 /proc/slabinfo | head -5
> biovec-1 7502216 7502296 16 226 1 : tunables 120 60 0 : slabdata 33196 33196 0
> bio 7502216 7502262 96 41 1 : tunables 120 60 0 : slabdata 182982 182982 0
Are you using RAID?
From: Neil Brown <neilb@cse.unsw.edu.au>
insert a missing bio_put when writing the md superblock.
Without this we have a steady growth in the "bio" slab.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/md/md.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/md/md.c~md-bio-leak-fix drivers/md/md.c
--- 25/drivers/md/md.c~md-bio-leak-fix 2005-06-27 22:29:13.000000000 -0700
+++ 25-akpm/drivers/md/md.c 2005-06-27 22:29:13.000000000 -0700
@@ -338,6 +338,7 @@ static int super_written(struct bio *bio
if (atomic_dec_and_test(&rdev->mddev->pending_writes))
wake_up(&rdev->mddev->sb_wait);
+ bio_put(bio);
return 0;
}
_
next prev parent reply other threads:[~2005-06-28 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 10:33 Marco Colombo
2005-06-28 9:18 ` Marco Colombo
2005-06-28 11:02 ` Andrew Morton [this message]
2005-06-28 13:38 ` Marco Colombo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628040217.0132d9cc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco@esi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome