From: Andi Kleen <ak@suse.de>
To: Vladimir Saveliev <vs@namesys.com>
Cc: Andi Kleen <ak@suse.de>, Hans Reiser <reiser@namesys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
reiserfs-list@namesys.com, Andrew Morton <akpm@osdl.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: reiser4 merging action list
Date: Tue, 28 Jun 2005 11:11:17 +0200 [thread overview]
Message-ID: <20050628091117.GJ8035@wotan.suse.de> (raw)
In-Reply-To: <1119947829.3495.25.camel@tribesman.namesys.com>
On Tue, Jun 28, 2005 at 12:37:11PM +0400, Vladimir Saveliev wrote:
> have neither prof.[ch], nor spinprof.[ch] and we removed already some
> debugging code from spin_macros.h.
Yes, i was looking at some older tree with reiser4. Sorry, just
ignore what is already done.
But still spin_macros.h should be completely removed imho. Such
custom lock wrappers are strongly discouraged because it
makes it hard for others to read your code.
> > statcnt.h: This is completely useless because you don't align
> > the individual fields for cache lines - so you will still
> > have false sharing everywhere. Also using NR_CPUS is nasty
> > because it can be very big - num_possible_cpus() is better.
> > It should use the new dynamic per cpu allocator.
> >
> statcnt.h is already removed.
Great.
-Andi
next prev parent reply other threads:[~2005-06-28 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42BB7B32.4010100@slaphack.com.suse.lists.linux.kernel>
[not found] ` <200506240334.j5O3YowB008100@laptop11.inf.utfsm.cl.suse.lists.linux.kernel>
[not found] ` <20050627092138.GD11013@nysv.org.suse.lists.linux.kernel>
[not found] ` <20050627124255.GB6280@thunk.org.suse.lists.linux.kernel>
[not found] ` <42C0578F.7030608@namesys.com.suse.lists.linux.kernel>
[not found] ` <20050627212628.GB27805@thunk.org.suse.lists.linux.kernel>
[not found] ` <42C084F1.70607@namesys.com.suse.lists.linux.kernel>
2005-06-28 2:58 ` Andi Kleen
2005-06-28 8:37 ` Vladimir Saveliev
2005-06-28 9:11 ` Andi Kleen [this message]
2005-06-28 9:16 ` Artem B. Bityuckiy
2005-06-24 3:17 reiser4 plugins David Masover
2005-06-24 3:34 ` Horst von Brand
2005-06-27 9:21 ` Markus Törnqvist
2005-06-27 12:42 ` Theodore Ts'o
2005-06-27 19:46 ` Hans Reiser
2005-06-27 21:26 ` Theodore Ts'o
2005-06-27 23:00 ` reiser4 merging action list Hans Reiser
2005-06-27 23:23 ` Andrew Morton
2005-06-29 5:41 ` Hans Reiser
2005-06-29 6:18 ` Pekka Enberg
2005-06-29 22:59 ` Hans Reiser
2005-06-28 9:41 ` Christoph Hellwig
2005-06-28 9:48 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628091117.GJ8035@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=reiserfs-list@namesys.com \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®