From: Tom Rini <trini@kernel.crashing.org>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@ozlabs.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC][PATCH] ppc misusing NTP's time_offset value
Date: Thu, 30 Jun 2005 10:41:44 -0700 [thread overview]
Message-ID: <20050630174144.GG13179@smtp.west.cox.net> (raw)
In-Reply-To: <1120082751.24889.120.camel@cog.beaverton.ibm.com>
On Wed, Jun 29, 2005 at 03:05:51PM -0700, john stultz wrote:
> Hey everyone,
>
> As part of my timeofday rework, I've been looking at the NTP code and I
> noticed that the PPC architecture is apparently misusing the NTP's
> time_offset (it is a terrible name!) value as some form of timezone
> offset. This could cause problems when time_offset changed by the NTP
> code.
>
> This patch changes the PPC code so it uses a more clear local variable:
> timezone_offset.
>
> Could a PPC maintainer verify this is correct?
As mentioned by Mikael, it's odd that this problem came up, since i
guess the wrong patch made it in. Andrew, please grab this if you
haven't already. Thanks.
Acked-by: Tom Rini <trini@kernel.crashing.org>
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-06-30 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 22:05 john stultz
2005-06-30 17:41 ` Tom Rini [this message]
2005-06-30 10:15 Mikael Pettersson
2005-06-30 11:53 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050630174144.GG13179@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®