From: "David S. Miller" <davem@davemloft.net>
To: linux-kernel@vger.kernel.org
Subject: empty_zero_page
Date: Tue, 05 Jul 2005 12:52:42 -0700 (PDT) [thread overview]
Message-ID: <20050705.125242.104033031.davem@davemloft.net> (raw)
Why does mm/filemap_xip.c make an explicit reference to
"empty_zero_page"? That's bogus, and ZERO_PAGE() is how
generic code should get at this thing.
In fact, what the mm/filemap_xip.c code wants is the page
struct, not the address of the page itself, because it
does a virt_to_page() on empty_zero_page in every such
reference.
This causes build failures for XIP support on sparc64.
When moving mm/filemap_xip.c over to ZERO_PAGE(), we will
need to determine the virtual address at which the ZERO_PAGE()
will be mapped. This shouldn't be difficult to determine,
and it's incredibly important to get this right, wrt. page
coloring concerns, particularly on MIPS which does make use
of the 'vaddr' argument to ZERO_PAGE().
next reply other threads:[~2005-07-05 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-05 19:52 David S. Miller [this message]
2005-07-07 12:22 ` empty_zero_page Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050705.125242.104033031.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®