From: Andrew Morton <akpm@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Fix printk format vs argument warning
Date: Tue, 5 Jul 2005 14:33:48 -0700 [thread overview]
Message-ID: <20050705143348.29348633.akpm@osdl.org> (raw)
In-Reply-To: <1284.1120593819@warthog.cambridge.redhat.com>
David Howells <dhowells@redhat.com> wrote:
>
> The attached patch makes the argument to this printk in
> calibrate_migration_costs() always long to match the format string.
That darn printk again. You wouldn't believe...
calibrate_migration_costs() causes a storm of boot-time output and I think
all those printks should be removed before this code goes up to Linus.
Maybe split out into a separate -mm-only patch?
> Signed-Off-By: David Howells <dhowells@redhat.com>
> ---
> warthog>diffstat -p1 format-arg-size-2612mm1-10.diff
> kernel/sched.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -uNrp linux-2.6.12-mm1/kernel/sched.c linux-2.6.12-mm1-cachefs-wander/kernel/sched.c
> --- linux-2.6.12-mm1/kernel/sched.c 2005-06-22 13:54:08.000000000 +0100
> +++ linux-2.6.12-mm1-cachefs-wander/kernel/sched.c 2005-06-22 14:10:57.000000000 +0100
> @@ -5572,7 +5572,7 @@ void __devinit calibrate_migration_costs
> printk("| migration cost matrix (max_cache_size: %d, cpu: %ld MHz):\n",
> max_cache_size,
> #ifdef CONFIG_X86
> - cpu_khz/1000
> + cpu_khz/1000L
> #else
It's currently %d in my tree. This is why I converted x86's cpu_khz from
unsigned long to unsigned, to match x86_64's.
next prev parent reply other threads:[~2005-07-05 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-05 20:03 David Howells
2005-07-05 21:33 ` Andrew Morton [this message]
2005-07-05 21:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050705143348.29348633.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®