From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S261339AbVGGQrT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S261339AbVGGQrT (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 7 Jul 2005 12:47:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261466AbVGGQmz
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 7 Jul 2005 12:42:55 -0400
Received: from ns2.suse.de ([195.135.220.15]:24006 "EHLO mx2.suse.de")
	by vger.kernel.org with ESMTP id S261448AbVGGQk1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2005 12:40:27 -0400
Date: Thu, 7 Jul 2005 18:40:24 +0200
From: Andi Kleen <ak@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Christoph Lameter <christoph@lameter.com>, Andi Kleen <ak@suse.de>,
       linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [another PATCH] Fix crash on boot in kmalloc_node IDE changes
Message-ID: <20050707164024.GK21330@wotan.suse.de>
References: <20050706133052.GF21330@wotan.suse.de> <Pine.LNX.4.62.0507070912140.27066@graphe.net> <Pine.LNX.4.58.0507070937130.3293@g5.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0507070937130.3293@g5.osdl.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2005 at 09:38:17AM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 7 Jul 2005, Christoph Lameter wrote:
> > 
> > Here is IMHO the right way to fix this. Test for the hwif != NULL and
> > test for pci_dev != NULL before determining the node number of the pci 
> > bus that the device is connected to.
> 
> I think this is pretty unreadable.
> 
> If you make it use a trivial inline function for the thing, I think that 
> would be ok, though.
> 
> Complex expressions are bad.

You could just use the previous patch I posted (hint hint...;) 

-Andi