From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261439AbVGGVPJ (ORCPT ); Thu, 7 Jul 2005 17:15:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261443AbVGGVPJ (ORCPT ); Thu, 7 Jul 2005 17:15:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:2022 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S261397AbVGGVPG (ORCPT ); Thu, 7 Jul 2005 17:15:06 -0400 Date: Thu, 7 Jul 2005 23:15:05 +0200 From: Andi Kleen To: Christoph Lameter Cc: Linus Torvalds , Bartlomiej Zolnierkiewicz , Andi Kleen , linux-ide@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [another PATCH] Fix crash on boot in kmalloc_node IDE changes Message-ID: <20050707211505.GM21330@wotan.suse.de> References: <20050706133052.GF21330@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2005 at 12:09:00PM -0700, Christoph Lameter wrote: > On Thu, 7 Jul 2005, Linus Torvalds wrote: > > > Yes. Except that if hwif is NULL, we'll have other oopses since we access > > that in other places. > > > > Why _is_ hwif NULL anyway? That's another, unrelated thing, and should > > probably have a separate check and an early return. > > I was wondering about that one as well. Andi brought it up. I don't know why hwif was NULL, but my kernel definitely crashed. hwif was NULL in the first function (I first misread the oops and thought it was pci_dev NULL, but it wasn't). For the second I didn't verify it was hwif or pci_dev NULL, but one of them was too. The setup was a Intel board with 1 PATA/4 SATA onboard and only a CD-ROM and a external Promise PATA controller with two PATA disks. -Andi