From: Albert Herranz <albert_herranz@yahoo.es>
To: Eric Biederman <ebiederm@xmission.com>, Vivek Goyal <vgoyal@in.ibm.com>
Cc: fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.13-rc2] kexec-ppc: fix for ksysfs crash_notes
Date: Sat, 9 Jul 2005 04:01:48 +0200 (CEST) [thread overview]
Message-ID: <20050709020148.64664.qmail@web25801.mail.ukl.yahoo.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
Hi,
Signed-off-by: Albert Herranz
<albert_herranz@yahoo.es>
The following patch prevents the crash dump helper
code found within kexec from breaking ppc which still
lacks crash dump functionality.
As discussed in [1], ksysfs crash_notes attribute
handling was left under CONFIG_KEXEC for simplicity
although it is not strictly kexec related.
We provide here a dummy definition for crash_notes on
ppc.
Cheers,
Albert
[1]
http://lists.osdl.org/mailman/htdig/fastboot/2005-April/001324.html
______________________________________________
Renovamos el Correo Yahoo!
Nuevos servicios, más seguridad
http://correo.yahoo.es
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 1992546426-kexec-ppc-ksysfs-crash_notes-fix.patch --]
[-- Type: text/x-patch; name="kexec-ppc-ksysfs-crash_notes-fix.patch", Size: 843 bytes --]
--- a/include/asm-ppc/kexec.h 2005-07-09 00:44:31.000000000 +0200
+++ b/include/asm-ppc/kexec.h 2005-07-09 03:17:20.000000000 +0200
@@ -27,6 +27,8 @@
#ifndef __ASSEMBLY__
+extern void *crash_notes;
+
struct kimage;
extern void machine_kexec_simple(struct kimage *image);
--- a/arch/ppc/kernel/machine_kexec.c 2005-07-09 00:44:25.000000000 +0200
+++ b/arch/ppc/kernel/machine_kexec.c 2005-07-09 03:45:18.000000000 +0200
@@ -28,6 +28,12 @@ typedef NORET_TYPE void (*relocate_new_k
const extern unsigned char relocate_new_kernel[];
const extern unsigned int relocate_new_kernel_size;
+/*
+ * Provide a dummy crash_notes definition while crash dump arrives to ppc.
+ * This prevents breakage of crash_notes attribute in kernel/ksysfs.c.
+ */
+void *crash_notes = NULL;
+
void machine_shutdown(void)
{
if (ppc_md.machine_shutdown)
reply other threads:[~2005-07-09 2:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050709020148.64664.qmail@web25801.mail.ukl.yahoo.com \
--to=albert_herranz@yahoo.es \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®