From: Andi Kleen <ak@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [patch] compress the stack layout of do_page_fault(), x86
Date: Sun, 10 Jul 2005 18:13:58 +0200 [thread overview]
Message-ID: <20050710161358.GE9068@wotan.suse.de> (raw)
In-Reply-To: <20050709194220.GA20791@elte.hu>
On Sat, Jul 09, 2005 at 09:42:20PM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <ak@suse.de> wrote:
>
> > Ingo Molnar <mingo@elte.hu> writes:
> > >
> > > +static void force_sig_info_fault(int si_signo, int si_code,
> > > + unsigned long address, struct task_struct *tsk)
> >
> > This won't work with a unit-at-a-time compiler which happily inlines
> > everything static with only a single caller. Use noinline
>
> this function has two callers.
Even then it's still better to mark it noinline, otherwise
a different inlining algorithm in a new compiler might do the wrong
thing. It's also useful documentation.
-Andi
next prev parent reply other threads:[~2005-07-10 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050709144116.GA9444@elte.hu.suse.lists.linux.kernel>
[not found] ` <20050709152924.GA13492@elte.hu.suse.lists.linux.kernel>
2005-07-09 17:05 ` Andi Kleen
2005-07-09 17:31 ` Arjan van de Ven
2005-07-09 19:15 ` Andi Kleen
2005-07-09 19:47 ` Arjan van de Ven
2005-07-09 19:42 ` Ingo Molnar
2005-07-10 16:13 ` Andi Kleen [this message]
2005-07-11 2:32 ` Ingo Molnar
2005-07-09 14:41 Ingo Molnar
2005-07-09 15:29 ` Ingo Molnar
2005-07-09 16:44 ` randy_dunlap
2005-07-09 16:46 ` Ingo Molnar
2005-07-10 3:35 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050710161358.GE9068@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®