From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alistair John Strachan <s0348365@sms.ed.ac.uk>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjanv@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-pcmcia@lists.infradead.org
Subject: PCMCIA stack reduction patch [Was: Re: Realtime Preemption, 2.6.12, Beginners Guide?]
Date: Sun, 10 Jul 2005 21:01:28 +0200 [thread overview]
Message-ID: <20050710190128.GI8758@dominikbrodowski.de> (raw)
In-Reply-To: <20050709132657.GA6088@elte.hu>
Hi,
On Sat, Jul 09, 2005 at 03:26:57PM +0200, Ingo Molnar wrote:
>
> > (gdb) ####################################
> > (gdb) # c02a0a26, stack size: 416 bytes #
> > (gdb) ####################################
> > (gdb) 0xc02a0a26 is in pcmcia_device_query (drivers/pcmcia/ds.c:436).
>
> ----
> this patch reduces the stack footprint of pcmcia_device_query() from 416
> bytes to 36 bytes. (patch only build-tested)
Applied and tested, but without the final hunk.
> @@ -856,7 +868,9 @@ static int bind_request(struct pcmcia_bu
> rescan:
> p_dev->cardmgr = p_drv;
>
> - pcmcia_device_query(p_dev);
> + ret = pcmcia_device_query(p_dev);
> + if (ret)
> + goto err_put_module;
>
> /*
> * Prevent this racing with a card insertion.
We don't check the return value here for a reason.
Thanks,
Dominik
next prev parent reply other threads:[~2005-07-10 19:02 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-06 11:57 Realtime Preemption, 2.6.12, Beginners Guide? Alistair John Strachan
2005-07-06 12:51 ` Alistair John Strachan
2005-07-06 13:39 ` Ingo Molnar
2005-07-06 15:58 ` Alistair John Strachan
2005-07-06 16:28 ` Ingo Molnar
2005-07-06 16:31 ` Alistair John Strachan
2005-07-06 13:31 ` Ingo Molnar
2005-07-06 15:55 ` Alistair John Strachan
2005-07-06 16:24 ` Ingo Molnar
2005-07-06 16:37 ` Alistair John Strachan
2005-07-06 16:56 ` Alistair John Strachan
2005-07-06 17:01 ` Ingo Molnar
2005-07-06 17:14 ` Alistair John Strachan
2005-07-06 17:27 ` Ingo Molnar
2005-07-06 18:23 ` Alistair John Strachan
2005-07-06 18:38 ` Ingo Molnar
2005-07-06 18:41 ` Ingo Molnar
2005-07-06 19:47 ` Alistair John Strachan
2005-07-06 20:44 ` Ingo Molnar
2005-07-06 21:00 ` Alistair John Strachan
2005-07-06 21:02 ` Ingo Molnar
2005-07-06 22:15 ` Alistair John Strachan
2005-07-06 23:08 ` Fernando Lopez-Lezcano
2005-07-07 6:04 ` Michal Schmidt
2005-07-07 10:25 ` Ingo Molnar
2005-07-07 9:46 ` Alistair John Strachan
2005-07-07 11:21 ` Alistair John Strachan
2005-07-07 11:29 ` Ingo Molnar
2005-07-07 11:37 ` Alistair John Strachan
2005-07-07 11:42 ` Ingo Molnar
2005-07-07 12:15 ` Alistair John Strachan
2005-07-07 12:29 ` Ingo Molnar
2005-07-07 13:38 ` Alistair John Strachan
2005-07-07 12:33 ` Alistair John Strachan
2005-07-08 9:47 ` Alistair John Strachan
2005-07-08 11:46 ` Ingo Molnar
2005-07-08 18:38 ` Alistair John Strachan
2005-07-08 19:12 ` USB storage does not work with 3GB of RAM, but does with 2G of RAM Jon Schindler
2005-07-08 19:25 ` Realtime Preemption, 2.6.12, Beginners Guide? Ingo Molnar
2005-07-08 19:31 ` Ingo Molnar
2005-07-08 19:34 ` Ingo Molnar
2005-07-08 19:48 ` Ingo Molnar
2005-07-08 19:55 ` Alistair John Strachan
2005-07-08 20:45 ` Alistair John Strachan
2005-07-09 11:58 ` Ingo Molnar
2005-07-09 14:07 ` Alistair John Strachan
2005-07-09 14:55 ` Ingo Molnar
2005-07-09 15:57 ` Ingo Molnar
2005-07-09 16:02 ` Ingo Molnar
2005-07-09 16:04 ` Alistair John Strachan
2005-07-11 13:55 ` Alistair John Strachan
2005-07-11 14:12 ` Ingo Molnar
2005-07-11 14:16 ` Ingo Molnar
2005-07-11 14:38 ` Alistair John Strachan
2005-07-11 14:43 ` Ingo Molnar
2005-07-11 15:50 ` Alistair John Strachan
2005-07-13 14:45 ` Ingo Molnar
2005-07-13 15:30 ` Ingo Molnar
2005-07-14 19:58 ` Alistair John Strachan
2005-07-14 20:16 ` Lee Revell
2005-07-15 22:12 ` Alistair John Strachan
2005-07-12 2:56 ` Lee Revell
2005-07-11 15:07 ` Ingo Molnar
2005-07-12 20:09 ` Lee Revell
2005-07-12 21:01 ` Chuck Harding
2005-07-13 10:39 ` Ingo Molnar
2005-07-13 12:29 ` Gene Heskett
2005-07-13 14:01 ` K.R. Foley
2005-07-13 19:41 ` Chuck Harding
2005-07-13 19:45 ` Ingo Molnar
2005-07-14 13:39 ` K.R. Foley
2005-07-14 12:50 ` Karsten Wiese
2005-07-14 13:56 ` K.R. Foley
2005-07-14 14:10 ` K.R. Foley
2005-07-14 14:11 ` K.R. Foley
2005-07-14 19:49 ` Chuck Harding
2005-07-16 17:15 ` Ingo Molnar
2005-07-16 19:01 ` K.R. Foley
2005-07-17 12:07 ` Karsten Wiese
2005-07-18 15:46 ` K.R. Foley
2005-07-19 11:14 ` Karsten Wiese
2005-07-19 13:35 ` Gene Heskett
2005-07-19 13:57 ` Ingo Molnar
2005-07-19 15:19 ` Gene Heskett
2005-07-19 23:00 ` Karsten Wiese
2005-07-09 12:41 ` Ingo Molnar
2005-07-09 12:46 ` Ingo Molnar
2005-07-09 13:05 ` Ingo Molnar
2005-07-11 22:48 ` William Weston
2005-07-12 13:53 ` Ingo Molnar
2005-07-09 13:13 ` Ingo Molnar
2005-07-09 13:26 ` Ingo Molnar
2005-07-10 19:01 ` Dominik Brodowski [this message]
2005-07-09 13:36 ` Ingo Molnar
2005-07-11 13:28 ` Paulo Marques
2005-07-08 11:48 ` Ingo Molnar
2005-07-08 17:42 ` Alistair John Strachan
2005-07-08 17:48 ` Jakub Jelinek
2005-07-08 18:12 ` Alistair John Strachan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050710190128.GI8758@dominikbrodowski.de \
--to=linux@dominikbrodowski.net \
--cc=akpm@osdl.org \
--cc=arjanv@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=mingo@elte.hu \
--cc=s0348365@sms.ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome