Re: [RFC][PATCH] split PCI probing code [1/9]

[Greg KH <greg@kroah.com>]

On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote:
> Adam Belay <abelay@novell.com> :
> [...]
> 
> Some nits + a suspect error branch. It seems nice otherwise.

If I'm correct, this patch only moves the code into different files, it
doesn't change any of it, so your comments apply to the current code
today, not Adam's changes :)

> > --- a/drivers/pci/bus/bus.c	1969-12-31 19:00:00.000000000 -0500
> > +++ b/drivers/pci/bus/bus.c	2005-07-10 22:32:53.000000000 -0400
> [...]
> > +struct pci_bus * pci_alloc_bus(void)
> > +{
> > +	struct pci_bus *b;
> > +
> > +	b = kmalloc(sizeof(*b), GFP_KERNEL);
> > +	if (b) {
> > +		memset(b, 0, sizeof(*b));
> 
> mm/slab.c provides kcalloc.

Ick, I hate that function call, this is nicer :)

thanks,

greg k-h