From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261744AbVGQBLQ (ORCPT ); Sat, 16 Jul 2005 21:11:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261883AbVGQBLQ (ORCPT ); Sat, 16 Jul 2005 21:11:16 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:40966 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261744AbVGQBLP (ORCPT ); Sat, 16 Jul 2005 21:11:15 -0400 Date: Sun, 17 Jul 2005 03:11:13 +0200 From: Adrian Bunk To: Andrew Morton Cc: mchehab@brturbo.com.br, video4linux-list@redhat.com, linux-kernel@vger.kernel.org Subject: [2.6 patch] VIDEO_SAA7134 must depend on SOUND Message-ID: <20050717011113.GB3613@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org VIDEO_SAA7134=y and SOUND=n results in the following compile error: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o(.text+0x4fafcb): In function `saa7134_initdev': : undefined reference to `unregister_sound_dsp' drivers/built-in.o(.text+0x4fb141): In function `saa7134_initdev': : undefined reference to `register_sound_dsp' drivers/built-in.o(.text+0x4fb17c): In function `saa7134_initdev': : undefined reference to `register_sound_mixer' drivers/built-in.o(.text+0x4fb339): In function `saa7134_finidev': : undefined reference to `unregister_sound_mixer' drivers/built-in.o(.text+0x4fb341): In function `saa7134_finidev': : undefined reference to `unregister_sound_dsp' make: *** [.tmp_vmlinux1] Error 1 <-- snip --> Signed-off-by: Adrian Bunk --- This patch was already sent on: - 2 Jul 2005 --- linux-2.6.13-rc1-mm1-full/drivers/media/video/Kconfig.old 2005-07-02 19:57:04.000000000 +0200 +++ linux-2.6.13-rc1-mm1-full/drivers/media/video/Kconfig 2005-07-02 20:01:33.000000000 +0200 @@ -249,7 +249,7 @@ config VIDEO_SAA7134 tristate "Philips SAA7134 support" - depends on VIDEO_DEV && PCI && I2C + depends on VIDEO_DEV && PCI && I2C && SOUND select VIDEO_BUF select VIDEO_IR select VIDEO_TUNER