From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261185AbVGTMqF (ORCPT ); Wed, 20 Jul 2005 08:46:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261192AbVGTMqF (ORCPT ); Wed, 20 Jul 2005 08:46:05 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:23211 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S261179AbVGTMqD (ORCPT ); Wed, 20 Jul 2005 08:46:03 -0400 Date: Wed, 20 Jul 2005 13:48:00 +0100 From: Matthew Wilcox To: Matt Domsch Cc: "Moore, Eric Dean" , Olaf Hering , Andrew Morton , linux-kernel@vger.kernel.org, James Bottomley , linux-scsi@vger.kernel.org Subject: Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion Message-ID: <20050720124800.GM10156@parcelfarce.linux.theplanet.co.uk> References: <91888D455306F94EBD4D168954A9457C03281EB4@nacos172.co.lsil.com> <20050720031249.GA18042@humbolt.us.dell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050720031249.GA18042@humbolt.us.dell.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote: > > What you illustrated above is not going to work. > > If your doing #ifndef around a function, such as scsi_device_online, it's > > not going to compile > > when scsi_device_online is already implemented in the kernel tree. > > The routine scsi_device_online is a function, not a define. For a define > > this would work. > > Sure it does, function names are defined symbols. uh, not to the preprocessor, they aren't. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain