mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
	lenz@cs.wisc.edu, rmk@arm.linux.org.uk, vojtech@suse.cz
Subject: Re: [patch,rfc] Support for touchscreen on sharp zaurus sl-5500
Date: Thu, 21 Jul 2005 17:40:28 +0200	[thread overview]
Message-ID: <20050721154028.GC21475@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <200507210050.26306.dtor_core@ameritech.net>

Hi!

> > +config TOUCHSCREEN_COLLIE
> > +	tristate "Collie touchscreen (for Sharp SL-5500)"
> > +	depends on MCP_UCB1200 && INPUT
> 
> I don't think you need && INPUT here.

Fixed.

> >  obj-$(CONFIG_TOUCHSCREEN_BITSY)	+= h3600_ts_input.o
> >  obj-$(CONFIG_TOUCHSCREEN_CORGI)	+= corgi_ts.o
> > +obj-$(CONFIG_TOUCHSCREEN_COLLIE)+= collie_ts.o
> 
> A tab would be nice.

Actually, that would break lining-up. But you have to look at
resulting file, not a patch.

> > +static int ucb1x00_ts_open(struct input_dev *idev)
> > +{
> > +	struct ucb1x00_ts *ts = (struct ucb1x00_ts *)idev;
> > +	int ret = 0;
> > +
> > +	if (down_interruptible(&ts->sem))
> > +		return -EINTR;
> > +
> > +	if (ts->use_count++ != 0)
> > +		goto out;
> > +
> 
> Please kill both ts->sem and ts->use_count - input core already serializes
> input_open and input_close.

Done. Still have to do the kthread conversion.

> > +
> > +MODULE_PARM(adcsync, "i");
> > +MODULE_PARM_DESC(adcsync, "Enable use of ADCSYNC signal");
> 
> Die, MODULE_PARM, die!

Dead :-).
							Pavel

-- 
Boycott Kodak -- for their patent abuse against Java.

  reply	other threads:[~2005-07-21 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-21  5:24 Pavel Machek
2005-07-21  5:50 ` Dmitry Torokhov
2005-07-21 15:40   ` Pavel Machek [this message]
2005-07-22  0:24 ` Nish Aravamudan
2005-07-22  1:28   ` Pavel Machek
2005-07-22  5:02     ` Nish Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050721154028.GC21475@atrey.karlin.mff.cuni.cz \
    --to=pavel@suse.cz \
    --cc=dtor_core@ameritech.net \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rpurdie@rpsys.net \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®