From: Sam Ravnborg <sam@ravnborg.org>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add -Wun-def to global CFLAGS
Date: Thu, 21 Jul 2005 21:47:18 +0000 [thread overview]
Message-ID: <20050721214718.GB12414@mars.ravnborg.org> (raw)
In-Reply-To: <20050721190209.GA13633@suse.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 461 bytes --]
On Thu, Jul 21, 2005 at 09:02:09PM +0200, Olaf Hering wrote:
>
> A recent change to the aic scsi driver removed two defines to detect
> endianness. cpp handles undefined strings as 0. As a result, the test turned
> into #if 0 == 0 and the wrong code was selected.
> Adding -Wundef to global CFLAGS will catch such errors.
To my suprise it did not spew out a lot of warnings in my build.
In the kernel we quite consitently use Â#ifdef - good!
Applied.
Sam
next prev parent reply other threads:[~2005-07-21 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-21 19:02 Olaf Hering
2005-07-21 21:47 ` Sam Ravnborg [this message]
2005-07-22 14:48 ` [PATCH] turn many #if $undefined_string into #ifdef $undefined_string Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050721214718.GB12414@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®