From: Pavel Machek <pavel@ucw.cz>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [warning: ugly, FYI] battery charging support for sharp sl-5500
Date: Tue, 26 Jul 2005 23:00:55 +0200 [thread overview]
Message-ID: <20050726210055.GA23224@elf.ucw.cz> (raw)
In-Reply-To: <1122304018.7942.61.camel@localhost.localdomain>
Hi!
> I have similar problems with the corgi battery driver which is probably
> even more of a mess than this. My conclusion is the whole lot needs
> rewriting in a nice fashion before it can be included in mainline. My
> work so far on the corgi code is here:
>
> http://www.rpsys.net/openzaurus/patches/corgi_power-r24.patch
+void corgikbd_setled_charge(int led_set)
+{
+ if (led_set)
+ GPSR0 = GPIO_bit(CORGI_GPIO_LED_ORANGE);
+ else
+ GPCR0 = GPIO_bit(CORGI_GPIO_LED_ORANGE);
+}
Ugh... GPSR0 / GPCR0 looks _very_ similar :-(. I thought I am seeing
an error.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
prev parent reply other threads:[~2005-07-26 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-25 5:46 Pavel Machek
2005-07-25 6:22 ` Pavel Machek
2005-07-30 9:26 ` Russell King
2005-07-30 14:21 ` Pavel Machek
2005-07-25 15:06 ` Richard Purdie
2005-07-26 20:52 ` Pavel Machek
2005-07-26 21:00 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050726210055.GA23224@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®