From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261448AbVG0FH4 (ORCPT ); Wed, 27 Jul 2005 01:07:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261527AbVG0FH4 (ORCPT ); Wed, 27 Jul 2005 01:07:56 -0400 Received: from smtp.osdl.org ([65.172.181.4]:34218 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261448AbVG0FHh (ORCPT ); Wed, 27 Jul 2005 01:07:37 -0400 Date: Tue, 26 Jul 2005 22:06:37 -0700 From: Andrew Morton To: "H. J. Lu" Cc: linux-kernel@vger.kernel.org Subject: Re: define-auxiliary-vector-size-at_vector_size.patch added to -mm tree Message-Id: <20050726220637.215803f3.akpm@osdl.org> In-Reply-To: <20050727045901.GA11392@lucon.org> References: <200507262144.j6QLiJVC015284@shell0.pdx.osdl.net> <20050727002608.GA7469@lucon.org> <20050726215323.0070c867.akpm@osdl.org> <20050727045901.GA11392@lucon.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "H. J. Lu" wrote: > > On Tue, Jul 26, 2005 at 09:53:23PM -0700, Andrew Morton wrote: > > "H. J. Lu" wrote: > > > > > > My patch breaks x86_64 build. This patch will fix x86_64 build. I am > > > also enclosing the updated full patch. > > > > It now breaks ppc64 > > > > include/asm/elf.h: In function `dump_task_regs': > > include/asm/elf.h:177: error: dereferencing pointer to incomplete type > > > > That's because pt_regs isn't known, because sched.h is including elf.h > > before pt_regs gets defined. This is a pretty fragile area I'm afraid. > > Should we creat a new header file like auxvector.h? Auxiliary isn't > ELF specific anyway. That would work.