From: "David S. Miller" <davem@davemloft.net>
To: rml@novell.com
Cc: akpm@osdl.org, paulus@samba.org, linux-kernel@vger.kernel.org,
ttb@tentacle.dhs.org
Subject: Re: [patch] inotify: ppc64 syscalls.
Date: Wed, 27 Jul 2005 13:27:01 -0700 (PDT) [thread overview]
Message-ID: <20050727.132701.115907512.davem@davemloft.net> (raw)
In-Reply-To: <1122485496.21253.170.camel@betsy>
From: Robert Love <rml@novell.com>
Date: Wed, 27 Jul 2005 13:31:36 -0400
> [ I don't think we need sys32 compatibility versions--and if we do, I
> failed in life. ]
add_watch and rm_watch both do, because system call arguments are
zero-extended by default for compat tasks, thus the "fd" arg needs
sign extension.
You'll notice that sys_ppc32.c has a ton of shims which purely
exist to sign extend "int" system call arguments. Sparc64 does
something similarly, but in assembler so that we don't eat the
overhead of a full stack frame just to sign extend arguments.
next prev parent reply other threads:[~2005-07-27 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 15:45 [patch] inotify: ppc32 syscalls Robert Love
2005-07-27 16:55 ` Andrew Morton
2005-07-27 17:31 ` [patch] inotify: ppc64 syscalls Robert Love
2005-07-27 20:27 ` David S. Miller [this message]
2005-07-27 20:31 ` Robert Love
2005-07-27 20:33 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050727.132701.115907512.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rml@novell.com \
--cc=ttb@tentacle.dhs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®