Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down

[Andrew Morton <akpm@osdl.org>]

Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
> 
> > > This adds support for powering Zaurus's video up and down.
> > 
> > I assume you have a new toy ;)
> 
> Actually very old toy, but I decided to make it working with 2.6
> kernel (needed for bluetooth). Which is not quite an easy task.
> 
> > >  PDA without
> > > screen is kind of useless, so it is quite important... I'll have to
> > > figure out how to really control the frontlight, because LCD without
> > > that is quite hard to read.
> > 
> > signed-off-by?
> 
> Sorry, will add.

I'll do it.

> > > @@ -0,0 +1,156 @@
> > > +/*
> > > + * Backlight control code for Sharp Zaurus SL-5500
> > > + *
> > > + * Copyright 2005 John Lenz <lenz@cs.wisc.edu>
> > > + * GPL v2
> > 
> > Who is the maintainer for this stuff?
> 
> I guess I'll maintain in.
> 
> > > +static struct locomo_dev *locomolcd_dev = NULL;
> > 
> > bah.
> 
> Well, sa1100fb_lcd_power is not provide us with void * we could use,
> and by definition you only have one frontlight in a PDA, so that
> should be okay...

"bah" means "there's no need to initialise this to NULL".