mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: "Brown, Len" <len.brown@intel.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: VIA PCI routing problem
Date: Thu, 28 Jul 2005 09:37:33 -0600	[thread overview]
Message-ID: <200507280937.33971.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <42E8CB27.4010100@yahoo.com.au>

On Thursday 28 July 2005 6:10 am, Nick Piggin wrote:
> I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12
> the USB mouse started moving around really slowly. Anyway, it turns
> out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Can you try this:

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-07-25 15:04:26.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-07-28 09:26:09.000000000 -0600
@@ -503,7 +503,7 @@
 
 	new_irq = dev->irq & 0xf;
 	pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
-	if (new_irq != irq) {
+	if (1 || new_irq != irq) {
 		printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n",
 			pci_name(dev), irq, new_irq);
 		udelay(15);	/* unknown if delay really needed */


If that doesn't help, remove it and see if this does:

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-07-25 15:04:26.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-07-28 09:27:23.000000000 -0600
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are


Can you also include "lspci" output?

  reply	other threads:[~2005-07-28 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28 12:10 Nick Piggin
2005-07-28 15:37 ` Bjorn Helgaas [this message]
2005-07-28 22:28   ` Nick Piggin
2005-07-28 18:36 Brown, Len
2005-07-28 22:43 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507280937.33971.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®