mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Ingo Molnar'" <mingo@elte.hu>
Cc: "Keith Owens" <kaos@ocs.com.au>, <David.Mosberger@acm.org>,
	"Andrew Morton" <akpm@osdl.org>, <linux-kernel@vger.kernel.org>,
	<linux-ia64@vger.kernel.org>
Subject: RE: Add prefetch switch stack hook in scheduler function
Date: Fri, 29 Jul 2005 00:22:43 -0700	[thread overview]
Message-ID: <200507290722.j6T7Mig07477@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050729070447.GA3032@elte.hu>

Ingo Molnar wrote on Friday, July 29, 2005 12:05 AM
> --- linux.orig/kernel/sched.c
> +++ linux/kernel/sched.c
> @@ -2869,7 +2869,14 @@ go_idle:
>  	 * its thread_info, its kernel stack and mm:
>  	 */
>  	prefetch(next->thread_info);
> -	prefetch(kernel_stack(next));
> +	/*
> +	 * Prefetch (at least) a cacheline below the current
> +	 * kernel stack (in expectation of any new task touching
> +	 * the stack at least minimally), and a cacheline above
> +	 * the stack:
> +	 */
> +	prefetch_range(kernel_stack(next) - MIN_KERNEL_STACK_FOOTPRINT,
> +		       MIN_KERNEL_STACK_FOOTPRINT + L1_CACHE_BYTES);
>  	prefetch(next->mm);


Doctor, it still hurts :-(

On ia64, we have two kernel stacks, one for outgoing task, and one for
incoming task.  for outgoing task, we haven't called switch_to() yet.
So the switch stack structure for 'current' will be allocated immediately
below current 'sp' pointer. For the incoming task, it was fully ctx'ed out
previously, so switch stack structure is immediate above kernel_stack(next).
It Would be beneficial to prefetch both stacks.


  parent reply	other threads:[~2005-07-29  7:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27 22:07 Chen, Kenneth W
2005-07-27 23:13 ` Andrew Morton
2005-07-27 23:23   ` david mosberger
2005-07-28  7:41     ` Ingo Molnar
2005-07-28  8:09       ` Keith Owens
2005-07-28  8:16         ` Ingo Molnar
2005-07-28  9:09           ` Ingo Molnar
2005-07-28 19:14             ` Chen, Kenneth W
2005-07-29  7:04               ` Ingo Molnar
2005-07-29  7:07                 ` Ingo Molnar
2005-07-29  8:30                   ` Eric Dumazet
2005-07-29  8:44                     ` Ingo Molnar
2005-07-31 16:27                     ` hashed spinlocks Daniel Walker
2005-07-31 18:46                       ` David S. Miller
2005-07-31 19:06                         ` Daniel Walker
2005-07-31 19:11                           ` David S. Miller
2005-07-31 19:16                             ` Daniel Walker
2005-07-29  8:30                   ` Add prefetch switch stack hook in scheduler function Chen, Kenneth W
2005-07-29  8:35                     ` Ingo Molnar
2005-07-29  8:39                       ` Chen, Kenneth W
2005-07-29  9:17                   ` Peter Zijlstra
2005-07-29 10:52                     ` Ingo Molnar
2005-07-29  7:22                 ` Chen, Kenneth W [this message]
2005-07-29  7:45                   ` Keith Owens
2005-07-29  8:02                     ` Chen, Kenneth W
2005-07-29  8:28                   ` Ingo Molnar
2005-07-29  9:02                     ` Russell King
2005-07-29  9:45                       ` Ingo Molnar
2005-07-29  7:38                 ` Keith Owens
2005-07-29  8:08                   ` Chen, Kenneth W
2005-07-28  8:31         ` Nick Piggin
2005-07-28  8:35           ` Ingo Molnar
2005-07-28  8:48             ` Nick Piggin
2005-07-28  9:16               ` Ingo Molnar
2005-07-28  9:19                 ` Ingo Molnar
2005-07-28  9:34                 ` Nick Piggin
2005-07-28 10:04                   ` Ingo Molnar
2005-07-28 10:29                     ` Nick Piggin
2005-07-29 15:18 linux
2005-07-29 15:49 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507290722.j6T7Mig07477@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=David.Mosberger@acm.org \
    --cc=akpm@osdl.org \
    --cc=kaos@ocs.com.au \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome