From: Christoph Hellwig <hch@lst.de>
To: rmk@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] switch fd1772.c from sleep_on to wait_event
Date: Sat, 30 Jul 2005 20:30:10 +0200 [thread overview]
Message-ID: <20050730183010.GB11877@lst.de> (raw)
doesn't make the local irq disabling around it less buggy, but at least
we replace the offender with the right kind of primitive.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/drivers/acorn/block/fd1772.c
===================================================================
--- linux-2.6.orig/drivers/acorn/block/fd1772.c 2005-04-30 10:17:13.000000000 +0200
+++ linux-2.6/drivers/acorn/block/fd1772.c 2005-05-27 14:15:43.000000000 +0200
@@ -1283,8 +1283,7 @@
if (fdc_busy) return;
save_flags(flags);
cli();
- while (fdc_busy)
- sleep_on(&fdc_wait);
+ wait_event(fdc_wait, !fdc_busy);
fdc_busy = 1;
ENABLE_IRQ();
restore_flags(flags);
reply other threads:[~2005-07-30 18:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050730183010.GB11877@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®