From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Sat, 30 Jul 2005 21:40:53 +0200 [thread overview]
Message-ID: <20050730194053.GB19768@mars.ravnborg.org> (raw)
In-Reply-To: <20050730185911.GA5481@infradead.org>
On Sat, Jul 30, 2005 at 07:59:11PM +0100, Christoph Hellwig wrote:
> On Sat, Jul 30, 2005 at 08:52:26PM +0200, Sam Ravnborg wrote:
> > Please - use tabs for indention, not for alignment.
> > The below would look rather messy with tabs=4.
> > Almost everywhere tabs are used in Makefiles it is plina wrong.
> > Tabs are brillient for indention but you cannot just assume 8 spaces = a
> > tab. Not even at the beginning of the line.
>
> as far as working on the kernel, yes you can assume that.
A bad assumption in several cases.
But if one never ever never use tabs != 8 they do not see the horror,
and so they probarly do not care.
For the Makefiles you will continue to see spaces used for alignmnet.
PS. Last word on this issue - I do not wan't to spend my linux time on a
sapce / versus tabs flamefest.
Sam
next prev parent reply other threads:[~2005-07-30 19:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-30 16:52 Adrian Bunk
2005-07-30 18:08 ` Andrew Morton
2005-07-30 19:44 ` Adrian Bunk
2005-07-30 18:52 ` Sam Ravnborg
2005-07-30 18:59 ` Christoph Hellwig
2005-07-30 19:40 ` Sam Ravnborg [this message]
2005-08-30 14:54 Adrian Bunk
2005-08-30 16:18 ` Olaf Hering
2005-08-30 16:29 ` Adrian Bunk
2005-08-30 16:38 ` Olaf Hering
2005-08-30 16:48 ` Adrian Bunk
2005-11-07 20:03 Adrian Bunk
2005-11-10 12:28 ` Andrew Morton
2005-11-11 2:12 ` Adrian Bunk
2005-11-11 2:24 ` Andrew Morton
2005-11-11 3:45 ` Randy.Dunlap
2005-11-11 20:18 ` Adrian Bunk
2005-11-11 20:20 ` Adrian Bunk
2005-11-11 20:36 ` Adrian Bunk
2005-11-11 21:24 ` Andrew Morton
2005-11-11 23:34 ` Sam Ravnborg
2005-11-12 0:33 ` Adrian Bunk
2005-11-23 22:34 Adrian Bunk
2005-11-23 23:09 ` Andrew Morton
2005-11-23 23:38 ` Adrian Bunk
2005-11-23 23:50 ` Andrew Morton
2005-11-24 0:13 ` Adrian Bunk
2006-06-28 16:54 Adrian Bunk
2006-07-06 16:37 Adrian Bunk
2006-07-06 18:05 ` Jesper Juhl
2006-07-06 18:20 ` Dave Jones
2006-07-07 3:36 ` Sam Ravnborg
2006-07-07 5:02 ` Valdis.Kletnieks
2006-07-07 6:42 ` Sam Ravnborg
2006-07-07 7:49 ` Adrian Bunk
2006-07-07 7:53 ` Milton Miller
2006-07-07 7:18 ` Adrian Bunk
2006-07-07 7:49 ` Heiko Carstens
2006-07-07 9:33 ` Sam Ravnborg
2006-07-07 17:10 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050730194053.GB19768@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®