mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, laforge@gnumonks.org
Subject: Re: git-net-fixup.patch added to -mm tree
Date: Sun, 31 Jul 2005 22:21:25 -0700	[thread overview]
Message-ID: <20050731222125.37ab12e8.akpm@osdl.org> (raw)
In-Reply-To: <20050731.221246.68159198.davem@davemloft.net>

"David S. Miller" <davem@davemloft.net> wrote:
>
> From: akpm@osdl.org
> Date: Sun, 31 Jul 2005 22:03:47 -0700
> 
> > From: Andrew Morton <akpm@osdl.org>
> > 
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
>  ...
> >  /* decrement reference count on a conntrack */
> > -extern void ip_conntrack_put(struct ip_conntrack *ct);
> > +static inline void
> > +ip_conntrack_put(struct ip_conntrack *ct)
> > +{
> > +	IP_NF_ASSERT(ct);
> > +	nf_conntrack_put(&ct->ct_general);
> > +}
> 
> You can instead just kill the EXPORT_SYMBOL_GPL() in
> ip_conntrack_standalone.c as that's the only reference outside of
> ip_conntrack_core.c
> 
> Harald?

Actually, that patch is just a fixup for a patch reject from the net-2.6.14
diff.  I do that sometimes when I get sick of fixing up the same reject
each time I pull the various trees.

(I'm not sure _why_ I'm getting a reject applying that diff.  Nothing else
touches that file.  git is not quite yet generating the linus->davem diff
which I want..)

  reply	other threads:[~2005-08-01  5:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200508010504.j7154m5B022440@shell0.pdx.osdl.net>
2005-08-01  5:12 ` David S. Miller
2005-08-01  5:21   ` Andrew Morton [this message]
2005-08-01  5:25     ` David S. Miller
2005-08-01  6:00       ` David S. Miller
2005-08-01  6:33   ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050731222125.37ab12e8.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=laforge@gnumonks.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®