From: Ashok Raj <ashok.raj@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Ashok Raj <ashok.raj@intel.com>, Andi Kleen <ak@muc.de>,
zwane@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: [patch 3/8] x86_64:Dont call enforce_max_cpus when hotplug is enabled
Date: Mon, 01 Aug 2005 13:20:20 -0700 [thread overview]
Message-ID: <20050801203011.178499000@araj-em64t> (raw)
In-Reply-To: <20050801202017.043754000@araj-em64t>
[-- Attachment #1: fix-enforce-max-cpu --]
[-- Type: text/plain, Size: 1627 bytes --]
No need to enforce_max_cpus when hotplug code is enabled. This
nukes out cpu_present_map and cpu_possible_map making it impossible to add
new cpus in the system.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
------------------------------------------------
arch/x86_64/kernel/smpboot.c | 40 +++++++++++++++++++++++-----------------
1 files changed, 23 insertions(+), 17 deletions(-)
Index: linux-2.6.13-rc4-mm1/arch/x86_64/kernel/smpboot.c
===================================================================
--- linux-2.6.13-rc4-mm1.orig/arch/x86_64/kernel/smpboot.c
+++ linux-2.6.13-rc4-mm1/arch/x86_64/kernel/smpboot.c
@@ -893,23 +893,6 @@ static __init void disable_smp(void)
cpu_set(0, cpu_core_map[0]);
}
-/*
- * Handle user cpus=... parameter.
- */
-static __init void enforce_max_cpus(unsigned max_cpus)
-{
- int i, k;
- k = 0;
- for (i = 0; i < NR_CPUS; i++) {
- if (!cpu_possible(i))
- continue;
- if (++k > max_cpus) {
- cpu_clear(i, cpu_possible_map);
- cpu_clear(i, cpu_present_map);
- }
- }
-}
-
#ifdef CONFIG_HOTPLUG_CPU
/*
* cpu_possible_map should be static, it cannot change as cpu's
@@ -929,6 +912,29 @@ static void prefill_possible_map(void)
for (i = 0; i < NR_CPUS; i++)
cpu_set(i, cpu_possible_map);
}
+
+/*
+ * Dont need this when we have hotplug enabled
+ */
+#define enforce_max_cpus(x)
+
+#else
+/*
+ * Handle user cpus=... parameter.
+ */
+static __init void enforce_max_cpus(unsigned max_cpus)
+{
+ int i, k;
+ k = 0;
+
+ for_each_cpu(i) {
+ if (++k > max_cpus) {
+ cpu_clear(i, cpu_possible_map);
+ cpu_clear(i, cpu_present_map);
+ }
+ }
+}
+
#endif
/*
--
next prev parent reply other threads:[~2005-08-01 21:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 20:20 [patch 0/8] Updated patches for x86_64 Ashok Raj
2005-08-01 20:20 ` [patch 1/8] x86_64: Reintroduce clustered_apic_check() " Ashok Raj
2005-08-01 22:36 ` Ashok Raj
2005-08-01 20:20 ` [patch 2/8] x86_64: create sysfs entries for cpu only for present cpus Ashok Raj
2005-08-04 10:37 ` Andi Kleen
2005-08-01 20:20 ` Ashok Raj [this message]
2005-08-04 10:41 ` [patch 3/8] x86_64:Dont call enforce_max_cpus when hotplug is enabled Andi Kleen
2005-08-04 16:28 ` Ashok Raj
2005-08-01 20:20 ` [patch 4/8] x86_64:Fix cluster mode send_IPI_allbutself to use get_cpu()/put_cpu() Ashok Raj
2005-08-04 10:43 ` Andi Kleen
2005-08-04 16:33 ` Ashok Raj
2005-08-01 20:20 ` [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode Ashok Raj
2005-08-04 10:51 ` Andi Kleen
2005-08-04 16:36 ` Ashok Raj
2005-08-04 17:27 ` Ashok Raj
2005-08-01 20:20 ` [patch 6/8] x86_64:Dont use Lowest Priority when using physical mode Ashok Raj
2005-08-01 20:20 ` [patch 7/8] x86_64:Use common functions in cluster and physflat mode Ashok Raj
2005-08-01 20:20 ` [patch 8/8] x86_64: Choose physflat for AMD systems only when >8 CPUS Ashok Raj
2005-08-04 10:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050801203011.178499000@araj-em64t \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®