From: Andi Kleen <ak@suse.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
ashok.raj@intel.com, Andi Kleen <ak@suse.de>,
Rajesh Shah <rajesh.shah@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] updated - Automatically enable bigsmp when we have more than 8 CPUs
Date: Thu, 4 Aug 2005 11:16:40 +0200 [thread overview]
Message-ID: <20050804091640.GK8266@wotan.suse.de> (raw)
In-Reply-To: <20050803160114.A5938@unix-os.sc.intel.com>
On Wed, Aug 03, 2005 at 04:01:14PM -0700, Venkatesh Pallipadi wrote:
>
> Below is the updated patch.
Looks good. Only minor nit.
> +++ linux-2.6.13-rc3-auto/arch/i386/kernel/setup.c 2005-08-03 14:33:34.450182216 -0700
> @@ -1593,8 +1594,13 @@ void __init setup_arch(char **cmdline_p)
> */
> acpi_boot_table_init();
> acpi_boot_init();
> -#endif
>
> +#ifdef CONFIG_X86_PC
> + if (def_to_bigsmp) {
> + printk(KERN_WARNING "More than 8 CPUs detected and CONFIG_X86_PC cannot handle it. Use CONFIG_X86_GENERICARCH or CONFIG_X86_BIGSMP.\n");
Isn't that printk line longer than 80 characters? Will it even fit
on the screen?
-Andi
prev parent reply other threads:[~2005-08-04 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 18:51 [PATCH] " Venkatesh Pallipadi
2005-08-03 10:20 ` Andi Kleen
2005-08-03 23:01 ` [PATCH] updated - " Venkatesh Pallipadi
2005-08-04 9:16 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050804091640.GK8266@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajesh.shah@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®