mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Roland Dreier <rolandd@cisco.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Move InfiniBand .h files
Date: Thu, 4 Aug 2005 21:22:29 +0200	[thread overview]
Message-ID: <20050804192229.GA26714@mars.ravnborg.org> (raw)
In-Reply-To: <52wtn18r7w.fsf@cisco.com>

On Thu, Aug 04, 2005 at 11:57:55AM -0700, Roland Dreier wrote:
>     Roland> Also, drivers/infiniband/include doesn't get put into the
>     Roland> /lib/modules/<ver>/build directory,
> 
>     Arjan> that is a symlink not a directory, and a symlink to the
>     Arjan> full source...
> 
> Sorry, I was too terse about the problem.  You're right, but typical
> distros don't ship full kernel source in their "support kernel builds"
> package.  And if I use an external build directory (ie "O=") then
> the symlink just points to my external build directory, which doesn't
> include the source to drivers/, just links to include/

If the external module uses a Kbuild file as explained in
Documentation/kbuild/makefiles.txt and then uses both O= and M=
when compiling the module there is no issue.

With respect to moving the .h files - please do so.
drivers/infiniband should only include header used in that same
directory. Not header files potentially uased by fs/.

	Sam

  reply	other threads:[~2005-08-04 19:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-04 17:32 Roland Dreier
2005-08-04 17:48 ` [openib-general] " Tom Duffy
2005-08-04 17:53 ` Arjan van de Ven
2005-08-04 18:26   ` [openib-general] " Grant Grundler
2005-08-04 19:51     ` Arjan van de Ven
2005-08-04 18:31   ` Roland Dreier
2005-08-04 18:38     ` Arjan van de Ven
2005-08-04 18:57       ` Roland Dreier
2005-08-04 19:22         ` Sam Ravnborg [this message]
2005-08-04 19:54           ` Christopher Friesen
2005-08-04 20:02             ` Sam Ravnborg
2005-08-04 19:51         ` Arjan van de Ven
2005-08-04 18:11 ` [openib-general] " Steve Wise
2005-08-04 18:20 ` Grant Grundler
2005-08-04 18:32   ` Roland Dreier
2005-08-04 21:38 ` James Lentini
2005-08-05  9:22 ` Christoph Hellwig
2005-08-05 16:08   ` Roland Dreier
2005-08-05 21:06     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050804192229.GA26714@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome