From: Andrew Morton <akpm@osdl.org>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: benoit.boissinot@ens-lyon.fr, schwidefsky@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: fix invalid kmalloc flags
Date: Fri, 5 Aug 2005 19:05:00 -0700 [thread overview]
Message-ID: <20050805190500.1a78322b.akpm@osdl.org> (raw)
In-Reply-To: <20050806020035.GA24455@kvack.org>
Benjamin LaHaise <bcrl@kvack.org> wrote:
>
> On Fri, Aug 05, 2005 at 05:36:29PM -0700, Andrew Morton wrote:
> > No, GFP_DMA should work OK. Except GFP_DMA doesn't have __GFP_VALID set.
> > It's strange that this didn't get noticed earlier.
> >
> > Ben, was there a reason for not giving GFP_DMA the treatment?
>
> Not really. Traditionally GFP_DMA was always mixed in with GFP_KERNEL or
> GFP_ATOMIC. It seems that GFP_DMA wasn't in the hunk of defines that all
> the other kernel flags were in, so if GFP_DMA is really valid all by itself,
> adding in the __GFP_VALID should be okay.
>
OK, it seems that pretty much all callers do remember to add GFP_KERNEL so
I guess we can treat this as a bug-which-ben's-patch-found and merge
Benoit's fix.
next prev parent reply other threads:[~2005-08-06 2:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-06 0:26 benoit.boissinot
2005-08-06 0:36 ` Andrew Morton
2005-08-06 2:00 ` Benjamin LaHaise
2005-08-06 2:05 ` Andrew Morton [this message]
2005-08-06 9:15 ` [PATCH] fix invalid kmalloc flags (GFP_DMA alone) Benoit Boissinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805190500.1a78322b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=benoit.boissinot@ens-lyon.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®