From: Karsten Wiese <annabellesgarden@yahoo.de>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARCH_HAS_IRQ_PER_CPU avoids dead code in __do_IRQ()
Date: Sun, 7 Aug 2005 13:56:07 +0200 [thread overview]
Message-ID: <200508071356.07139.annabellesgarden@yahoo.de> (raw)
In-Reply-To: <200508071307.26221.ioe-lkml@rameria.de>
Am Sonntag, 7. August 2005 13:07 schrieb Ingo Oeser:
> Last argument: Many kernel developers -- including Linus --
> don't like "#if" in C files and prefer them in headers.
> Their reasons might be similiar to my own.
What about writing
if(CHECK_IRQ_PER_CPU(desc->status)) {
...
}
in __do_IRQ(),
and
#if defined(ARCH_HAS_IRQ_PER_CPU)
#define IRQ_PER_CPU 256 /* IRQ is per CPU */
#define CHECK_IRQ_PER_CPU(var) ((var) & IRQ_PER_CPU)
#else
#define CHECK_IRQ_PER_CPU(var) 0
#endif
in "include/linux/irq.h" then?
Gruesse,
Karsten
___________________________________________________________
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
prev parent reply other threads:[~2005-08-07 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-06 16:14 Karsten Wiese
2005-08-06 21:28 ` Ingo Oeser
2005-08-07 10:25 ` Karsten Wiese
2005-08-07 11:07 ` Ingo Oeser
2005-08-07 11:56 ` Karsten Wiese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508071356.07139.annabellesgarden@yahoo.de \
--to=annabellesgarden@yahoo.de \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®