From: "David S. Miller" <davem@davemloft.net>
To: linux-kernel@vger.kernel.org
Cc: linville@redhat.com, torvalds@osdl.org
Subject: pci_update_resource() getting called on sparc64
Date: Mon, 08 Aug 2005 07:12:11 -0700 (PDT) [thread overview]
Message-ID: <20050808.071211.74753610.davem@davemloft.net> (raw)
Some recent change last week causes pci_update_resource()
to be invoked on sparc64 now, and this is why my workstation
couldn't cleanly boot into current 2.6.13 when I tried to
remotely try out some new kernels while I was in the UK.
This thing is supposed to only be invoked if you support
power management, and therefore we made it just BUG() on
sparc64.
But some change last week causes it to be invoked when
the radeonfb driver registers a device, and that's why
my workstation failed to boot up current 2.6.13 kernels.
pci_restore_bars() is the only invoker of pci_update_resource()
and that should only be invoked by pci_set_power_state() if
the local variable "need_restore" is set, which occurs if
if (dev->current_state >= PCI_D3hot) {
if (!(pmcsr & PCI_PM_CTRL_NO_SOFT_RESET))
need_restore = 1;
and I don't see how that can happen to my radeon which is
fully operational when the kernel boots and the radeon device
is registered.
I'm tempted to just make pci_update_resource() not BUG() any
longer, but that definitely feels like the wrong way to fix
this. And in any event, I'd like to get this fixed before
2.6.13 goes out the door.
Does anyone have a clue what change made last week could have
made this start happening?
next reply other threads:[~2005-08-08 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 14:12 David S. Miller [this message]
2005-08-08 14:44 ` Greg KH
2005-08-08 17:33 ` David S. Miller
2005-08-08 18:32 ` Linus Torvalds
2005-08-08 16:08 ` Greg KH
2005-08-08 19:32 ` David S. Miller
2005-08-08 19:42 ` Greg KH
2005-08-08 19:54 ` David S. Miller
2005-08-08 20:02 ` Greg KH
2005-08-08 20:19 ` [PCI PATCH]: Make sparc64 use setup-res.c David S. Miller
2005-08-08 19:56 ` pci_update_resource() getting called on sparc64 Linus Torvalds
2005-08-08 21:38 ` John W. Linville
2005-08-08 21:43 ` David S. Miller
2005-08-08 21:59 ` John W. Linville
2005-08-09 9:54 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050808.071211.74753610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome