mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Alexander Nyberg <alexn@telia.com>,
	Christoph Lameter <christoph@lameter.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [SLAB] __builtin_return_address use without FRAME_POINTER causes boot failure
Date: Wed, 10 Aug 2005 11:48:26 +0200	[thread overview]
Message-ID: <20050810094826.GA16911@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <42F8E243.2060505@colorfullife.com>

On Tue, 9 August 2005 19:05:07 +0200, Manfred Spraul wrote:
> Alexander Nyberg wrote:
> 
> >My fault, I introduced a debugging patch (i think i cc'ed you on it)
> >which used __builtin_return_address([12]) to save traces of who the
> >caller of an object is.
> >
> Ups. I still have your original mail in my inbox.
> The correct way is check the whole stack and store all pointers that are 
> in kernel_text_address(). See store_stack_info() in mm/slab.c.

Ugly.  Wouldn't make a difference on i386, but other architectures
actually don't need to play function-guessing games.  Maybe we could
create an architecture-provided function like
void *get_next_stack_function(void* last_function);

For asm-generic, this would do the i386 style stack guessing, while
other architectures can walk a stack frame for it.

[ Yes, I realize that noone cares enough to actually do it, including
me, but it still would be nice. ]

Jörn

-- 
You can take my soul, but not my lack of enthusiasm.
-- Wally

      reply	other threads:[~2005-08-10  9:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08 20:57 Christoph Lameter
2005-08-08 21:37 ` Manfred Spraul
2005-08-08 21:51   ` Andrew Morton
2005-08-08 21:53   ` Alexander Nyberg
2005-08-09 17:05     ` Manfred Spraul
2005-08-10  9:48       ` Jörn Engel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050810094826.GA16911@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=akpm@osdl.org \
    --cc=alexn@telia.com \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®