mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: pcihpd-discuss@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, greg@kroah.com,
	rajesh.shah@intel.com
Subject: Re: [Pcihpd-discuss] [PATCH] use bus_slot number for name
Date: Wed, 10 Aug 2005 16:01:54 +0100	[thread overview]
Message-ID: <20050810150154.GB16724@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1123269366.8917.39.camel@whizzy>

On Fri, Aug 05, 2005 at 12:16:06PM -0700, Kristen Accardi wrote:
> For systems with multiple hotplug controllers, you need to use more than
> just the slot number to uniquely name the slot.  Without a unique slot
> name, the pci_hp_register() will fail.  This patch adds the bus number
> to the name.

That doesn't make much sense.  The slot number should at least be unique
to the chassis, if not to the whole machine.  HP's large machines with
multiple cabinets encode the cabinet number in the return from _SUN.
It ends up as something like 80103 for a large machine while still being
merely slot 3 for the smaller machines.

IOW, I think this is a firmware bug which needs to be fixed there.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  parent reply	other threads:[~2005-08-10 14:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-05 19:16 Kristen Accardi
2005-08-05 19:51 ` Dave Jones
2005-08-05 20:47   ` Kristen Accardi
2005-08-05 21:31   ` Kristen Accardi
2005-08-05 22:11     ` [Pcihpd-discuss] " Greg KH
2005-08-05 21:33   ` Greg KH
2005-08-10 15:01 ` Matthew Wilcox [this message]
2005-08-16 22:47   ` [Pcihpd-discuss] " Kristen Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050810150154.GB16724@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=greg@kroah.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    --cc=rajesh.shah@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®