From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964933AbVHKAUh (ORCPT ); Wed, 10 Aug 2005 20:20:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964913AbVHKAUh (ORCPT ); Wed, 10 Aug 2005 20:20:37 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:35760 "EHLO smtps.tip.net.au") by vger.kernel.org with ESMTP id S964884AbVHKAUg (ORCPT ); Wed, 10 Aug 2005 20:20:36 -0400 Date: Thu, 11 Aug 2005 10:20:23 +1000 From: Stephen Rothwell To: "Luck, Tony" Cc: hch@lst.de, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] consolidate sys_ptrace Message-Id: <20050811102023.703ebb5e.sfr@canb.auug.org.au> In-Reply-To: References: X-Mailer: Sylpheed version 2.0.0 (GTK+ 2.6.9; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Aug 2005 09:59:01 -0700 "Luck, Tony" wrote: > > >Some architectures have a too different ptrace so we have to exclude > >them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to > >keep their implementations. > > So it should be no surprise that this patch works ok for ia64, but here > is the ACK anyway. > > >+#ifndef __ARCH_SYS_PTRACE > > Most of the existing "#define ARCH_foo" uses don't have a prepended > "__" (current score is 20 to 3). So there is a small question of As opposed to the 86 unique HAVE_ARCH_ defines ... (like: HAVE_ARCH_COPY_AND_CSUM_FROM_USER, HAVE_ARCH_COPY_SIGINFO etc) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/