From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1750924AbVHLSkl@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750924AbVHLSkl (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 12 Aug 2005 14:40:41 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750923AbVHLSkl
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 12 Aug 2005 14:40:41 -0400
Received: from fmr22.intel.com ([143.183.121.14]:6302 "EHLO
	scsfmr002.sc.intel.com") by vger.kernel.org with ESMTP
	id S1750921AbVHLSkk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Aug 2005 14:40:40 -0400
Date: Fri, 12 Aug 2005 11:40:33 -0700
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andi Kleen <ak@suse.de>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
       Martin Wilck <martin.wilck@fujitsu-siemens.com>,
       linux-kernel@vger.kernel.org
Subject: Re: APIC version and 8-bit APIC IDs
Message-ID: <20050812114033.B15541@unix-os.sc.intel.com>
References: <42FC8461.2040102@fujitsu-siemens.com.suse.lists.linux.kernel> <p73pssj2xdz.fsf@verdi.suse.de> <42FCA23C.7040601@fujitsu-siemens.com> <20050812133248.GN8974@wotan.suse.de> <42FCA97E.5010907@fujitsu-siemens.com> <42FCB86C.5040509@fujitsu-siemens.com> <20050812145725.GD922@wotan.suse.de> <20050812111916.A15541@unix-os.sc.intel.com> <20050812182228.GE22901@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20050812182228.GE22901@wotan.suse.de>; from ak@suse.de on Fri, Aug 12, 2005 at 08:22:28PM +0200
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 12, 2005 at 08:22:28PM +0200, Andi Kleen wrote:
> > --- linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c~	2005-08-12 10:19:07.037696416 -0700
> > +++ linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c	2005-08-12 10:19:38.098974384 -0700
> > @@ -707,7 +707,7 @@
> >  
> >  	processor.mpc_type = MP_PROCESSOR;
> >  	processor.mpc_apicid = id;
> > -	processor.mpc_apicver = 0x10; /* TBD: lapic version */
> > +	processor.mpc_apicver = GET_APIC_VERSION(apic_read(APIC_LVR));
> 
> That code executes on the BP. What happens when different CPUs have
> different APIC versions?  Not sure if that can happen, but it 
> still looks a bit like "cheating.

Not sure if we ever support CPUs with different APIC versions. That will
probably require some ACPI SPEC changes too..

I would say, for now just follow the i386 code.

thanks,
suresh