From: Peter Martuccelli <peterm@redhat.com>
To: len.brown@intel.com
Cc: akpm@osdl.com, linux-kernel@vger.kernel.org, peterm@redhat.com
Subject: [PATCH 2.6.12.4] ACPI oops during ipmi_si driver init
Date: Fri, 12 Aug 2005 15:44:44 -0400 [thread overview]
Message-ID: <200508121944.j7CJiifE005958@redrum.boston.redhat.com> (raw)
Hello Len,
Stumbled into this problem working on the ipmi_si driver. When the
ipmi_si driver initialization fails the acpi_tb_get_table
call, after rsdt_info has been allocated, acpi_get_firmware_table()
will oops trying to reference off rsdt_info->pointer in the cleanup
code. The following patch resolves the problem. I noticed this
problem on six different systems, all with slightly different stack
traces, but they all fail in the same manner.
Patch applies cleanly to 2.6.12.4. Tested at various sites and on
various systems, no additional problems detected.
Signed-off-by: peterm@redhat.com
Regards,
Peter
--- linux-2.6.9/drivers/acpi/tables/tbxfroot.c.orig 2005-08-11 23:44:01.000000000 -0400
+++ linux-2.6.9/drivers/acpi/tables/tbxfroot.c 2005-08-11 23:52:57.000000000 -0400
@@ -293,9 +293,12 @@ acpi_get_firmware_table (
cleanup:
- acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
- ACPI_MEM_FREE (rsdt_info);
-
+ if (rsdt_info) {
+ if (rsdt_info->pointer) {
+ acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
+ }
+ ACPI_MEM_FREE (rsdt_info);
+ }
if (header) {
ACPI_MEM_FREE (header);
}
next reply other threads:[~2005-08-12 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 19:44 Peter Martuccelli [this message]
2005-08-15 22:13 ` Bjorn Helgaas
2005-08-16 20:50 ` Peter Martuccelli
2005-08-17 20:30 ` Corey Minyard
2005-08-17 21:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508121944.j7CJiifE005958@redrum.boston.redhat.com \
--to=peterm@redhat.com \
--cc=akpm@osdl.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®