From: Michael Iatrou <m.iatrou@freemail.gr>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, ajoshi@shell.unixbox.com
Subject: Re: [PATCH] configurable debug info from radeonfb old driver
Date: Sun, 14 Aug 2005 13:01:48 +0300 [thread overview]
Message-ID: <200508141301.49640.m.iatrou@freemail.gr> (raw)
In-Reply-To: <20050814012506.79987caf.akpm@osdl.org>
When the date was Sunday 14 August 2005 11:25, Andrew Morton wrote:
> Michael Iatrou <m.iatrou@freemail.gr> wrote:
> >
> > Hi,
> >
> > Currently, radeonfb old driver always prints debugging informations. This
> > patch makes debug info reporting configurable.
> >
> >
> > diff -urN linux-2.6.13-rc6/drivers/video/Kconfig linux-2.6.13-rc6.new/drivers/video/Kconfig
> > --- linux-2.6.13-rc6/drivers/video/Kconfig 2005-08-14 00:48:34.000000000 +0300
> > +++ linux-2.6.13-rc6.new/drivers/video/Kconfig 2005-08-14 00:54:10.000000000 +0300
> > @@ -936,6 +936,15 @@
> > There is a product page at
> > <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
> >
> > +config FB_RADEON_OLD_DEBUG
> > + bool "Enable debug output from Old Radeon driver"
> > + depends on FB_RADEON_OLD
> > + default n
> > + help
> > + Say Y here if you want the Radeon driver to output all sorts
> > + of debugging informations to provide to the maintainer when
> > + something goes wrong.
> > +
> > config FB_RADEON
> > tristate "ATI Radeon display support"
> > depends on FB && PCI
> > diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
> > --- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
> > +++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 00:55:16.000000000 +0300
> > @@ -80,7 +80,11 @@
> > #include <video/radeon.h>
> > #include <linux/radeonfb.h>
> >
> > -#define DEBUG 1
> > +#ifdef CONFIG_FB_RADEON_OLD_DEBUG
> > +#define DEBUG 1
> > +#else
> > +#define DEBUG 0
> > +#endif
> >
> > #if DEBUG
> > #define RTRACE printk
>
> That's probably a bit fancier than we really need. How about we just set
> DEBUG to zero?
That's an option too.
diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
--- linux-2.6.13-rc6/drivers/video/radeonfb.c 2005-06-19 14:49:29.000000000 +0300
+++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c 2005-08-14 12:58:10.000000000 +0300
@@ -80,7 +80,7 @@
#include <video/radeon.h>
#include <linux/radeonfb.h>
-#define DEBUG 1
+#define DEBUG 0
#if DEBUG
#define RTRACE printk
--
Michael Iatrou
prev parent reply other threads:[~2005-08-14 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-13 22:18 Michael Iatrou
2005-08-14 8:25 ` Andrew Morton
2005-08-14 10:01 ` Michael Iatrou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508141301.49640.m.iatrou@freemail.gr \
--to=m.iatrou@freemail.gr \
--cc=ajoshi@shell.unixbox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®