From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932264AbVHOIc5 (ORCPT ); Mon, 15 Aug 2005 04:32:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932256AbVHOIc5 (ORCPT ); Mon, 15 Aug 2005 04:32:57 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:43274 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S932250AbVHOIc4 (ORCPT ); Mon, 15 Aug 2005 04:32:56 -0400 Date: Mon, 15 Aug 2005 09:32:44 +0100 From: Russell King To: Matthew Wilcox Cc: Greg KH , James.Smart@Emulex.Com, Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Cox Subject: Re: [PATCH] add transport class symlink to device object Message-ID: <20050815093244.A19811@flint.arm.linux.org.uk> Mail-Followup-To: Matthew Wilcox , Greg KH , James.Smart@Emulex.Com, Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Cox References: <9BB4DECD4CFE6D43AA8EA8D768ED51C201AD35@xbl3.ma.emulex.com> <20050813213955.GB19235@kroah.com> <20050814150231.GA9466@parcelfarce.linux.theplanet.co.uk> <20050814232525.A27481@flint.arm.linux.org.uk> <20050815004303.GB9466@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20050815004303.GB9466@parcelfarce.linux.theplanet.co.uk>; from matthew@wil.cx on Mon, Aug 15, 2005 at 01:43:03AM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote: > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: > > Eww. Do you really want one struct device per tty with all the > > memory each one eats? > > > > If that's really what you want you need to talk to Alan and not me. > > Alan looks after tty level stuff, I look after serial level stuff. > > The above is a tty level issue not a serial level issue. > > mmm. I don't know whether it's really a tty level issue or a serial > issue. The only tty classes with corresponding devices are the serial > ones, at least on my system. If this is the case, then the right fix > would seem to be something like creating a new struct device for each > serial port, then making that the uart_port->dev instead of the pci_dev > or whatever. What's the reason for enforcing one struct device per struct class_dev ? I thought one of the points of class_dev was that you could have multiple of them per struct device. Please note that I have other commitments for the next fortnight, so my time this week is _very_ limited. Can this wait until September? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core