From: Andi Kleen <ak@suse.de>
To: zach@vmware.com
Cc: akpm@osdl.org, chrisw@osdl.org, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org
Subject: Re: [PATCH 0/6] i386 virtualization patches, Set 3
Date: Tue, 16 Aug 2005 01:24:00 +0200 [thread overview]
Message-ID: <20050815232400.GV27628@wotan.suse.de> (raw)
In-Reply-To: <200508152258.j7FMw9p8005295@zach-dev.vmware.com>
On Mon, Aug 15, 2005 at 03:58:09PM -0700, zach@vmware.com wrote:
> I was going to attempt to clean up the math-emu code to make it use the
> nice new segment and descriptor table accessors, but it quickly became
> apparent that this would be a long, tedious, error prone process that
> would eventually result in the death of a large section of my brain.
> In addition, it is not very fun to test this on the actual hardware it
> is designed to run on (although I did manage to track down a 386 with
> detachable i387 coprocessor, the owner is not sure it still boots).
> Someday it would be nice to have an audit of this code; it appears to
> be riddled with bugs relating to segmentation, for example it assumes
> LDT segments on overrides, does not use the mm->context semaphore to
> protect LDT access, and generally looks scarily out of date in both
> function and appearance.
Perhaps the best would be to just remove it. Near all 386s should be far
beyond their MTBF by now. Mark it CONFIG_BROKEN and if nobody complains for
one or two releases remove it completely.
The ugly verify_area 386 bugfix workaround code could go at the same
time.
-Andi
next prev parent reply other threads:[~2005-08-15 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 22:58 zach
2005-08-15 23:24 ` Andi Kleen [this message]
2005-08-15 23:27 ` David Lang
2005-08-15 23:35 ` Andi Kleen
2005-08-16 3:08 ` Brian Gerst
2005-08-16 3:33 ` Zachary Amsden
2005-08-16 7:44 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050815232400.GV27628@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®