From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965160AbVHPJSD (ORCPT ); Tue, 16 Aug 2005 05:18:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965162AbVHPJSB (ORCPT ); Tue, 16 Aug 2005 05:18:01 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:14759 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S965160AbVHPJSA (ORCPT ); Tue, 16 Aug 2005 05:18:00 -0400 Date: Tue, 16 Aug 2005 10:17:58 +0100 From: Christoph Hellwig To: Rolf Eike Beer Cc: Linux Kernel Mailing List , linux-scsi@vger.kernel.org, James Bottomley , Andrew Morton , Linus Torvalds , Bolke de Bruin Subject: Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver Message-ID: <20050816091758.GA21378@infradead.org> Mail-Followup-To: Christoph Hellwig , Rolf Eike Beer , Linux Kernel Mailing List , linux-scsi@vger.kernel.org, James Bottomley , Andrew Morton , Linus Torvalds , Bolke de Bruin References: <200508051202.07091@bilbo.math.uni-mannheim.de> <200508091806.45341@bilbo.math.uni-mannheim.de> <200508161111.08070@bilbo.math.uni-mannheim.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200508161111.08070@bilbo.math.uni-mannheim.de> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote: > cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent > constant SCSI_RESET_ERROR it causes just another unneeded compile error. That was the old reset handler. Do you actually have this hardware? The driver is pretty much un-recoverable and mkp is working on a from scratch driver for this hardware - I don't think putting any work into the driver makes sense unless you have a very urgent need to use it.