mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: zach@vmware.com, akpm@osdl.org, chrisl@vmware.com,
	chrisw@osdl.org, hpa@zytor.com, Keir.Fraser@cl.cam.ac.uk,
	linux-kernel@vger.kernel.org, m+Ian.Pratt@cl.cam.ac.uk,
	mbligh@mbligh.org, pratap@vmware.com,
	virtualization@lists.osdl.org, zwame@arm.linux.org.uk
Subject: Re: [PATCH 1/14] i386 / Make write ldt return error code
Date: Tue, 16 Aug 2005 17:06:18 -0700	[thread overview]
Message-ID: <20050817000618.GT7762@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050816234330.GF27628@wotan.suse.de>

* Andi Kleen (ak@suse.de) wrote:
> On Wed, Aug 10, 2005 at 09:52:51PM -0700, zach@vmware.com wrote:
> > Xen requires error returns from the hypercall to update LDT entries,
> > and this generates completely equivalent code on native.
> 
> I don't think that is something we want. Nothing in the callers will check
> the errors anyways. If Xen has such a requirement it should kill
> the guest when it is violated, otherwise they will be ignored.

In this case the callers do propagate the error (unless you mean
userspace doesn't check return value from syscall, which is same problem
if copy_from_user failed, for example).  Xen has done some more wrapping
of the hypercalls to be effectively synchronous exceptions on error.
Keir, Ian, is that preferred method going forward?

thanks,
-chris

  reply	other threads:[~2005-08-17  0:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-11  4:52 zach
2005-08-11 12:57 ` Chris Wright
2005-08-16 23:43 ` Andi Kleen
2005-08-17  0:06   ` Chris Wright [this message]
2005-08-17  0:12     ` Andi Kleen
2005-08-17  0:22       ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050817000618.GT7762@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=chrisl@vmware.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=mbligh@mbligh.org \
    --cc=pratap@vmware.com \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    --cc=zwame@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®