From: Christoph Hellwig <hch@infradead.org>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] Cleanup line-wrapping in pgtable.h
Date: Wed, 17 Aug 2005 18:56:01 +0100 [thread overview]
Message-ID: <20050817175601.GA19570@infradead.org> (raw)
In-Reply-To: <1124300739.3139.16.camel@localhost.localdomain>
> +static inline int pte_user(pte_t pte)
> + { return (pte).pte_low & _PAGE_USER; }
Once you start reformatting things please make sure the result version
matches the documented codingstyle. That would be:
static inline int pte_user(pte_t pte)
{
return (pte).pte_low & _PAGE_USER;
}
Quite a bit more verbose, but also a lot better readable.
next prev parent reply other threads:[~2005-08-17 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 17:45 Adam Litke
2005-08-17 17:56 ` Christoph Hellwig [this message]
2005-08-17 19:48 ` Alexey Dobriyan
2005-08-17 18:00 ` Tommy Reynolds
2005-08-17 18:19 ` Dave Hansen
2005-08-22 9:29 ` Pavel Machek
2005-08-22 21:11 ` Matthew Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050817175601.GA19570@infradead.org \
--to=hch@infradead.org \
--cc=agl@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome