From: Andi Kleen <ak@suse.de>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andi Kleen <ak@suse.de>, Eric Dumazet <dada1@cosmosbay.com>,
Benjamin LaHaise <bcrl@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand.
Date: Thu, 18 Aug 2005 04:57:28 +0200 [thread overview]
Message-ID: <20050818025727.GY3996@wotan.suse.de> (raw)
In-Reply-To: <4303F7E8.5030705@yahoo.com.au>
> You don't want to always have bad performance though, so you
> could attempt to allocate if either the pointer is null _or_ it
> points to the global structure?
Remember it's after a GFP_KERNEL OOM. If that fails most likely
you have deadlocked somewhere else already because Linux's handling
of that is so bad. Suboptimal readahead somewhere is the smallest
of your problems.
-Andi
next prev parent reply other threads:[~2005-08-18 2:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050810164655.GB4162@linux.intel.com>
[not found] ` <20050810.135306.79296985.davem@davemloft.net>
[not found] ` <20050810211737.GA21581@linux.intel.com>
[not found] ` <430391F1.9080900@cosmosbay.com>
[not found] ` <20050817211829.GK27628@wotan.suse.de>
[not found] ` <4303AEC4.3060901@cosmosbay.com>
[not found] ` <20050817215357.GU3996@wotan.suse.de>
2005-08-18 0:40 ` Eric Dumazet
2005-08-18 1:05 ` Andi Kleen
2005-08-18 2:43 ` David S. Miller
2005-08-18 7:14 ` Eric Dumazet
2005-08-18 7:18 ` David S. Miller
2005-08-18 2:52 ` Nick Piggin
2005-08-18 2:57 ` Andi Kleen [this message]
2005-08-18 3:00 ` Nick Piggin
2005-08-18 1:39 ` Coywolf Qi Hunt
2005-08-18 6:51 ` Eric Dumazet
2005-08-18 9:05 ` [PATCH] Put the very large file_ra_state outside of 'struct file' Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050818025727.GY3996@wotan.suse.de \
--to=ak@suse.de \
--cc=bcrl@linux.intel.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®