mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
	vandrove@vc.cvut.cz, Andrew Morton <akpm@osdl.org>,
	linware@sh.cvut.cz, fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Kernel bug: Bad page state: related to generic symlink code and mmap
Date: Fri, 19 Aug 2005 17:21:21 +0100	[thread overview]
Message-ID: <20050819162121.GC29811@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0508190855350.3412@g5.osdl.org>

On Fri, Aug 19, 2005 at 09:07:35AM -0700, Linus Torvalds wrote:
> Hmm.. NFS _does_ use the page cache for symlinks, but uses it slightly 
> differently: instead of relying on the page cache entry being the same 
> when freeing the page, it just caches the page it looked up in the page 
> cache (ie "nfs_follow_link()" does look up the page cache, but then hides 
> the page pointer inside the page data itself (uglee), and thus does not 
> depend on the mapping staying the same (nfs_put_link() just takes the page 
> from the symlink data).

For NFS that was done exactly to deal with cache invalidation.  IIRC, I've
convinced myself that it wasn't going to happen on ncpfs and happily
abstained from duplicating the NFS variant.

  reply	other threads:[~2005-08-19 16:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-19 11:14 Anton Altaparmakov
2005-08-19 14:20 ` Al Viro
2005-08-19 15:44   ` Anton Altaparmakov
2005-08-19 15:58     ` Al Viro
2005-08-19 16:07     ` Linus Torvalds
2005-08-19 16:21       ` Al Viro [this message]
2005-08-19 16:21       ` Linus Torvalds
2005-08-19 16:43         ` Linus Torvalds
2005-08-19 16:53           ` Al Viro
2005-08-19 18:02             ` Al Viro
2005-08-19 18:00               ` Christoph Hellwig
2005-08-19 19:38                 ` Al Viro
2005-08-19 19:41                   ` Matthew Wilcox
2005-08-19 19:43                     ` Al Viro
2005-08-19 21:19                       ` Christoph Hellwig
2005-08-19 20:35                   ` Linus Torvalds
2005-08-19 21:20                     ` Anton Altaparmakov
2005-08-19 21:35                       ` Linus Torvalds
2005-08-19 21:42                     ` Al Viro
2005-08-19 19:16               ` Mika Penttilä
2005-08-19 19:40                 ` Al Viro
2005-08-19 19:50                   ` Mika Penttilä
2005-08-19 20:46           ` Anton Altaparmakov
2005-08-19 20:55             ` Linus Torvalds
2005-08-19 21:39               ` Anton Altaparmakov
2005-08-19 22:04                 ` Linus Torvalds
2005-08-19 23:15                   ` Al Viro
2005-08-19 23:17                     ` Al Viro
2005-08-20  1:08                     ` Linus Torvalds
2005-08-20  1:15                       ` Al Viro
2005-08-20 12:49                   ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050819162121.GC29811@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linware@sh.cvut.cz \
    --cc=torvalds@osdl.org \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®