From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: s390 build fix.
Date: Sun, 21 Aug 2005 06:11:31 +0100 [thread overview]
Message-ID: <20050821051131.GH29811@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050821043839.GA28550@redhat.com>
On Sun, Aug 21, 2005 at 12:38:39AM -0400, Dave Jones wrote:
> {standard input}: Assembler messages:
> {standard input}:397: Error: symbol `.Litfits' is already defined
> {standard input}:585: Error: symbol `.Litfits' is already defined
>
> Newer gcc's inline this it seems, which blows up.
Eeek... Much easier (and already sent to Linus):
diff -urN RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c
--- RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c 2005-08-10 10:37:46.000000000 -0400
+++ RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c 2005-08-10 20:38:56.000000000 -0400
@@ -46,9 +46,9 @@
"lra 3,0(%4)\n"
"lr 5,%5\n"
"diag 2,4,0x8\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"ar 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lr %0,4\n"
"lr %1,5\n"
: "=d" (return_code), "=d" (return_len)
@@ -64,9 +64,9 @@
"sam31\n"
"diag 2,4,0x8\n"
"sam64\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"agr 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lgr %0,4\n"
"lgr %1,5\n"
: "=d" (return_code), "=d" (return_len)
next prev parent reply other threads:[~2005-08-21 5:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-21 4:38 Dave Jones
2005-08-21 5:11 ` Al Viro [this message]
2005-08-21 5:26 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050821051131.GH29811@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®