From: Chris Wedgwood <cw@f00f.org>
To: 7eggert@gmx.de
Cc: cHitman <samartsev@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH for changing of DVD speed via ioctl() call
Date: Sun, 21 Aug 2005 19:37:55 -0700 [thread overview]
Message-ID: <20050822023755.GA22851@taniwha.stupidest.org> (raw)
In-Reply-To: <E1E6vvy-0000hI-Hj@be1.lrz>
On Sun, Aug 21, 2005 at 09:56:45PM +0200, Bodo Eggert wrote:
> The parameter value should IMHO be a pointer to a struct {
> unsigned long long maxspeed; // (with 0 being the magic max. value?)
> int facility; /* 0=general speed, 2=general read, 4=read data,
> 6=read audio, 8=read raw ... whatever is supported
> n+1 = s/read/write/ */
> }
Passing pointers inside ioctl's is horrible IMO and if we can avoid it
we should. It's just asking for problems.
next prev parent reply other threads:[~2005-08-22 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E0p1-3vc-23@gated-at.bofh.it>
2005-08-21 19:56 ` Bodo Eggert
2005-08-22 2:37 ` Chris Wedgwood [this message]
2005-08-22 13:42 ` Bodo Eggert
2005-08-21 15:55 cHitman
2005-08-22 9:09 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050822023755.GA22851@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=7eggert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=samartsev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®