From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbVHVVgi (ORCPT ); Mon, 22 Aug 2005 17:36:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751260AbVHVVgD (ORCPT ); Mon, 22 Aug 2005 17:36:03 -0400 Received: from zeus1.kernel.org ([204.152.191.4]:5505 "EHLO zeus1.kernel.org") by vger.kernel.org with ESMTP id S1751252AbVHVVf5 (ORCPT ); Mon, 22 Aug 2005 17:35:57 -0400 Date: Mon, 22 Aug 2005 19:44:14 +0530 From: Dinakar Guniguntala To: Ingo Molnar Cc: John Hawkes , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, pj@sgi.com, nickpiggin@yahoo.com.au, akpm@osdl.org Subject: Re: [PATCH] ia64 cpuset + build_sched_domains() mangles structures Message-ID: <20050822141414.GB7686@in.ibm.com> Reply-To: dino@in.ibm.com References: <43074328.MailOXV1UXUHF@jackhammer.engr.sgi.com> <20050822070834.GA16722@elte.hu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline In-Reply-To: <20050822070834.GA16722@elte.hu> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 22, 2005 at 09:08:34AM +0200, Ingo Molnar wrote: > > in terms of 2.6.14, the replacement patch below also does what i always > wanted to do: to merge the ia64-specific build_sched_domains() code back > into kernel/sched.c. I've done this by taking your improved dynamic > build-domains code and putting it into kernel/sched.c. > Ingo, one change required to your patch and the exclusive cpuset functionality seems to work fine on a NUMA ppc64 box. I am still running some of my dynamic sched domain tests. So far it seems to be holding ok. Any idea why the ia64 stuff was forked in the first place? The patch below is on top of your patch. (This is the earlier patch John had sent) -Dinakar --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="sd-numa.patch" diff -Naurp linux-2.6.13-rc6.ingo/kernel/sched.c linux-2.6.13-rc6/kernel/sched.c --- linux-2.6.13-rc6.ingo/kernel/sched.c 2005-08-22 19:23:06.000000000 +0530 +++ linux-2.6.13-rc6/kernel/sched.c 2005-08-22 19:36:45.000000000 +0530 @@ -5192,7 +5192,7 @@ next_sg: #endif /* Attach the domains */ - for_each_online_cpu(i) { + for_each_cpu_mask(i, *cpu_map) { struct sched_domain *sd; #ifdef CONFIG_SCHED_SMT sd = &per_cpu(cpu_domains, i); --2fHTh5uZTiUOsy+g--